-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace video player by ExoPlayer #8132
Conversation
To potential test user: All in all feedback sounds promising, so I'll go this way, and generate a new test version. EDIT: I removed the test file, as many testers replied, thanks for that! |
I am interested in alpha testing the apk too with the new player, we just reuploaded our full nextcloud to reset old encryption, and video playing on android is still buggy. Working perfectly on Chrome/Firefox Mobile |
I removed it for now, but will update this PR soon and then there is a new version to test. |
Any updates on this? |
@tobiasKaminsky any update here? :) |
Working very nice, videos are starting instandly |
For me the same, also with local external storage on the server side. |
Thanks, I tested it and it starts indeed smoothly, and changing orientation of the phone is also working smoothly, BUT, I do cope with 3 problems
But thanks for your effort, it is already super nice to see the movies starting so quickly ! Best Regards |
@lftsy thanks for your feedback. Fullscreen is for now shown in option menu. |
CodacyLint
SpotBugs (new)
SpotBugs (master)
|
master-IT test failed, but no output was generated. Maybe a preliminary stage failed. |
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1301-IT-master-08-25 |
stable-IT test failed, but no output was generated. Maybe a preliminary stage failed. |
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1301-IT-stable-08-28 |
"Stream with" out of the player menu doesn't have any effect. |
@tobiasKaminsky MKV videos play but you only see a black screen and only hear the audio. I can share the file via mail if you want. |
Will this pullrequest also make it possible to cast content to chromecast and such? |
I don't think. But you can very easy use cromecast if you stream to vlc, bubbleupnp oder allcast |
Good evening everybody and sorry for the delay in answering ** Actions**
** Problems I coped with**
Best Regards |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
I'll merge this now, after CI. @lftsy thanks for your feedback, can you create new issues once this happen again? |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/8132.apk |
master-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1514-Unit-master-08-15 |
stable-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1514-Unit-stable-08-19 |
🎉 |
Honestly exoplayer is way worse than the original player, at least with the original player when it was unable to process either the video format or the audio format, it would stop player when you closed it, exoplayer just starts spinning up processes like its' life depends on it, is there really no better alternative than this? Video player is essentially broken 99% of the time |
Fix #5917
Fix #5800
Fix #4204
Fix #3601
Fix #7647
Fix #3061
Fix #3064
TODO:
Built in video player is known to having problems with streaming, buffering, etc.
Exoplayer should perform better: https://github.com/google/ExoPlayer
I invite every user reporting streaming/playback issues to test this via provided apk.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me
Testing
Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.
unit tests
instrumented tests
UI tests